Skip to content

Simplify enums: remove unnecessary code and reuse enum name #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sczyh30 merged 1 commit into from
Mar 4, 2021
Merged

Simplify enums: remove unnecessary code and reuse enum name #2032

sczyh30 merged 1 commit into from
Mar 4, 2021

Conversation

@quaff
Copy link
Contributor

@quaff quaff commented Feb 19, 2021

Remove unnecessary code and reuse enum name.

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sczyh30 sczyh30 requested a review from cdfive February 19, 2021 02:48
@cdfive
Copy link
Collaborator

cdfive commented Feb 19, 2021

It looks good, which make the code more concise.
I test it with sentinel-dubbo-adapter of lower version(1.8.1) and enums of new version(1.8.1-SNAPSHOT), it works well and seems to be no compatibility issue.

cdfive
cdfive approved these changes Feb 19, 2021
View reviewed changes
Copy link
Collaborator

@cdfive cdfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@sczyh30 sczyh30 added the kind/enhancement Category issues or prs related to enhancement. label Feb 23, 2021
@sczyh30 sczyh30 changed the title Simplify enums Simplify enums: remove unnecessary code and reuse enum name Feb 23, 2021
@sczyh30 sczyh30 merged commit df871b0 into alibaba:master Mar 4, 2021
@sczyh30
Copy link
Member

sczyh30 commented Mar 4, 2021

Thanks for contributing!

hughpearse pushed a commit to hughpearse/Sentinel that referenced this pull request Jun 2, 2021
@quaff
Simplify enums: reuse enum name and remove unnecessary code (alibaba#…
43c9f4f 
…2032)
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 4, 2021
@quaff
Simplify enums: reuse enum name and remove unnecessary code (alibaba#…
d01bca1 
…2032)
linkolen added a commit to shivagowda/Sentinel that referenced this pull request Aug 4, 2021
@linkolen
Merge pull request #22 from shivagowda/taha-master-patches-20
80dd995 
Simplify enums: reuse enum name and remove unnecessary code (alibaba#2032)
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 14, 2021
@quaff
Simplify enums: reuse enum name and remove unnecessary code (alibaba#…
a7aa884 
…2032)
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 14, 2021
@quaff
Simplify enums: reuse enum name and remove unnecessary code (alibaba#…
946c90f 
…2032)
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 16, 2021
@quaff
Simplify enums: reuse enum name and remove unnecessary code (alibaba#…
2de70fa 
…2032)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sczyh30 sczyh30 sczyh30 approved these changes

@cdfive cdfive cdfive approved these changes

@jasonjoo2010 jasonjoo2010 Awaiting requested review from jasonjoo2010

Assignees

No one assigned

Labels

kind/enhancement Category issues or prs related to enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@quaff @CLAassistant @cdfive @sczyh30