Skip to content

Conversation

@zhangxn8
Copy link
Contributor

2、the design is reference dubbo

Describe what this PR does / why we need it

    support motan rpc

Does this pull request fix one issue?

    Fixes #1803

Describe how you did it

  the design is reference dubbo

Describe how to verify it

  Have sentinel-demo-motan module,run SentinelMotanConsumerService and SentinelMotanProviderService

Special notes for reviews

2、the design is reference dubbo
@CLAassistant
Copy link

CLAassistant commented Oct 27, 2020

CLA assistant check
All committers have signed the CLA.

@zhangxn8 zhangxn8 mentioned this pull request Oct 28, 2020
@sczyh30 sczyh30 added area/integrations Issues or PRs related to integrations with open-source components to-review To review labels Oct 29, 2020
@sczyh30 sczyh30 changed the title 1、support motan rpc [Adapter] Support motan RPC Oct 29, 2020
@sczyh30 sczyh30 linked an issue Nov 5, 2020 that may be closed by this pull request
@zhangxn8 zhangxn8 requested a review from cdfive November 7, 2020 15:20
@zhangxn8 zhangxn8 requested a review from cdfive November 8, 2020 14:31
@cdfive
Copy link
Collaborator

cdfive commented Nov 8, 2020

Run the demo and it works well, and I have no further idea.
Please help solving the CI problem @sczyh30 @jasonjoo2010

@sczyh30 sczyh30 added this to the 1.8.1 milestone Nov 10, 2020
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 6719cee into alibaba:master Dec 5, 2020
@sczyh30
Copy link
Member

sczyh30 commented Dec 5, 2020

Nice work. Thanks for contributing!

@sczyh30 sczyh30 removed the to-review To review label Dec 5, 2020
hughpearse pushed a commit to hughpearse/Sentinel that referenced this pull request Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/integrations Issues or PRs related to integrations with open-source components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support motan RPC

4 participants