Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule configuration support for parameter flow control in Sentinel Dashboard #176

Merged
merged 6 commits into from
Oct 12, 2018

Conversation

sczyh30
Copy link
Member

@sczyh30 sczyh30 commented Oct 11, 2018

Describe what this PR does / why we need it

Add rule configuration support for parameter flow control in Sentinel Dashboard.

Does this pull request fix one issue?

Resolves #175

Describe how you did it

  • Update dashboard API client to support authority and parameter flow commands
  • Add REST API controller for parameter flow rules in dashboard
  • Add pages for configuring parameter flow rules
  • Update dependencies: upgrade Spring Boot to 2.x and remove unused dependencies
  • Other refinements

Describe how to verify it

Run the dashboard to verify the functions.

Special notes for reviews

None

- Upgrade Spring Boot to 2.0.x
- Remove unused dependencies

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30 sczyh30 added the to-review To review label Oct 11, 2018
@sczyh30 sczyh30 requested a review from CarpenterLee October 11, 2018 09:35
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #176 into master will increase coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #176      +/-   ##
============================================
+ Coverage     50.47%   51.55%   +1.07%     
- Complexity      817      836      +19     
============================================
  Files           139      139              
  Lines          4741     4799      +58     
  Branches        675      678       +3     
============================================
+ Hits           2393     2474      +81     
+ Misses         2067     2033      -34     
- Partials        281      292      +11
Impacted Files Coverage Δ Complexity Δ
...n/java/com/alibaba/csp/sentinel/log/RecordLog.java 72.41% <0%> (-4.06%) 5% <0%> (+1%)
...aba/csp/sentinel/slots/logger/EagleEyeLogUtil.java 90% <0%> (-3.34%) 4% <0%> (+2%)
...com/alibaba/csp/sentinel/log/CommandCenterLog.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../csp/sentinel/slots/block/degrade/DegradeRule.java 55.55% <0%> (+1.23%) 14% <0%> (ø) ⬇️
...a/com/alibaba/csp/sentinel/node/StatisticNode.java 66.66% <0%> (+1.58%) 18% <0%> (+1%) ⬆️
...ain/java/com/alibaba/csp/sentinel/log/LogBase.java 80.43% <0%> (+6.24%) 5% <0%> (ø) ⬇️
...a/csp/sentinel/slots/statistic/base/LongAdder.java 34.04% <0%> (+17.02%) 11% <0%> (+7%) ⬆️
...ibaba/csp/sentinel/eagleeye/BaseLoggerBuilder.java 77.77% <0%> (+19.15%) 11% <0%> (+5%) ⬆️
...a/csp/sentinel/slots/statistic/base/Striped64.java 56.25% <0%> (+30.2%) 8% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ae079c...a9de164. Read the comment docs.

Copy link
Contributor

@CarpenterLee CarpenterLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit b06bb02 into master Oct 12, 2018
@sczyh30 sczyh30 deleted the dashboard/0.2.1 branch October 16, 2018 02:10
@sczyh30 sczyh30 removed the to-review To review label Oct 16, 2018
Arlmls pushed a commit to Arlmls/Sentinel that referenced this pull request Jan 8, 2019
… Dashboard (alibaba#176)

- Update dashboard API client to support authority and parameter flow commands
- Add REST API controller for parameter flow rules in dashboard
- Add pages for configuring parameter flow rules
- Update dependencies: upgrade Spring Boot to 2.x and remove unused dependencies
- Other refinements

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support rule configuration for parameter flow control in Sentinel Dashboard
3 participants