Skip to content

Conversation

@PeineLiang
Copy link
Contributor

@PeineLiang PeineLiang commented Sep 23, 2020

Describe what this PR does / why we need it

The rocketmq demo unable to run and stop because of miss namesrv configuration, and now fixed.

Does this pull request fix one issue?

Fixes #1651

Describe how you did it

Describe how to verify it

Special notes for reviews

@sczyh30
Copy link
Member

sczyh30 commented Nov 9, 2020

Hi, could you please add some PR descriptions?

@sczyh30 sczyh30 added the area/example Issues or PRs related to examples label Nov 16, 2020
@PeineLiang
Copy link
Contributor Author

Hi, could you please add some PR descriptions?

added, please check it.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit fe59485 into alibaba:master Feb 3, 2021
@sczyh30
Copy link
Member

sczyh30 commented Feb 3, 2021

Thanks for contributing!

shenbaoyong pushed a commit to shenbaoyong/Sentinel that referenced this pull request Feb 5, 2021
- The demo was unable to run and stop because of missing namesrv configuration, and now fixed.
hughpearse pushed a commit to hughpearse/Sentinel that referenced this pull request Jun 2, 2021
- The demo was unable to run and stop because of missing namesrv configuration, and now fixed.
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 2, 2021
- The demo was unable to run and stop because of missing namesrv configuration, and now fixed.
linkolen added a commit to shivagowda/Sentinel that referenced this pull request Aug 2, 2021
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 14, 2021
- The demo was unable to run and stop because of missing namesrv configuration, and now fixed.
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 14, 2021
- The demo was unable to run and stop because of missing namesrv configuration, and now fixed.
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 15, 2021
- The demo was unable to run and stop because of missing namesrv configuration, and now fixed.
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 15, 2021
- The demo was unable to run and stop because of missing namesrv configuration, and now fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/example Issues or PRs related to examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

关于rocketmq demo问题

2 participants