-
Notifications
You must be signed in to change notification settings - Fork 8.2k
bugfix:rocketmq demo can not finish #1757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi, could you please add some PR descriptions? |
Contributor
Author
added, please check it. |
sczyh30
approved these changes
Feb 3, 2021
Member
sczyh30
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Member
|
Thanks for contributing! |
shenbaoyong
pushed a commit
to shenbaoyong/Sentinel
that referenced
this pull request
Feb 5, 2021
- The demo was unable to run and stop because of missing namesrv configuration, and now fixed.
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
- The demo was unable to run and stop because of missing namesrv configuration, and now fixed.
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 2, 2021
- The demo was unable to run and stop because of missing namesrv configuration, and now fixed.
linkolen
added a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 2, 2021
Improve RocketMQ integration example (alibaba#1757)
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 14, 2021
- The demo was unable to run and stop because of missing namesrv configuration, and now fixed.
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 14, 2021
- The demo was unable to run and stop because of missing namesrv configuration, and now fixed.
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 15, 2021
- The demo was unable to run and stop because of missing namesrv configuration, and now fixed.
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 15, 2021
- The demo was unable to run and stop because of missing namesrv configuration, and now fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
The rocketmq demo unable to run and stop because of miss namesrv configuration, and now fixed.
Does this pull request fix one issue?
Fixes #1651
Describe how you did it
Describe how to verify it
Special notes for reviews