[ISSUE #943]Fix Console add rules Chinese garbled #1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1207 +/- ##
============================================
- Coverage 43.06% 43.05% -0.02%
+ Complexity 1571 1570 -1
============================================
Files 337 337
Lines 9888 9888
Branches 1334 1334
============================================
- Hits 4258 4257 -1
Misses 5101 5101
- Partials 529 530 +1
Continue to review full report at Codecov.
|
sczyh30
reviewed
Dec 19, 2019
...simple-http/src/main/java/com/alibaba/csp/sentinel/transport/command/http/HttpEventTask.java
Outdated
Show resolved
Hide resolved
sczyh30
added
the
kind/enhancement
Member
|
Thanks for contributing! |
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
…coding in SentinelApiClient (alibaba#1207) * Fix content-type parsing bug in `sentinel-transport-simple-http` module * Change the charset of UrlEncodedFormEntity to UTF-8 in SentinelApiClient of the dashboard to support non-ASCII characters
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
…ST request (alibaba#1260) * Better compatibility of the dashboard to legacy and new sentinel-transport-simple-http (on Content-Type header), related to alibaba#1207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
support Chinese rules in sentinel console
Does this pull request fix one issue?
Fixes #943
Describe how you did it
change UrlEncodedFormEntity with utf-8
The client will get: content-type: application/x-www-form-urlencoded; charset=utf-8
change the judge equals to "application/x-www-form-urlencoded"
Describe how to verify it
sentinel-demo-spring-webmvc as a client
run client and console, add chinese rules
Special notes for reviews