Skip to content

Conversation

@mark8866
Copy link
Contributor

@mark8866 mark8866 commented Sep 20, 2019

Describe what this PR does / why we need it

Does this pull request fix one issue?

Resolves #992

Describe how you did it

Describe how to verify it

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Sep 20, 2019

CLA assistant check
All committers have signed the CLA.

@sczyh30 sczyh30 added area/gateway-flow-control Issues or PRs related to API gateway flow control to-review To review labels Sep 20, 2019
@mark8866 mark8866 changed the title Feature: 网关规则和自定义api规则增加对写数据源的支持 Feature: 网关规则和自定义api规则动态修改增加对写数据源的支持 Sep 20, 2019
@sczyh30
Copy link
Member

sczyh30 commented Sep 20, 2019

Could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=1057

@codecov-io
Copy link

codecov-io commented Sep 20, 2019

Codecov Report

Merging #1057 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #1057     +/-   ##
===========================================
- Coverage      43.1%   43.01%   -0.1%     
+ Complexity     1493     1492      -1     
===========================================
  Files           317      317             
  Lines          9295     9321     +26     
  Branches       1269     1271      +2     
===========================================
+ Hits           4007     4009      +2     
- Misses         4794     4818     +24     
  Partials        494      494
Impacted Files Coverage Δ Complexity Δ
...ommon/command/UpdateGatewayRuleCommandHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...UpdateGatewayApiDefinitionGroupCommandHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/com/alibaba/csp/sentinel/node/ClusterNode.java 95.23% <0%> (-4.77%) 7% <0%> (-1%)
...p/sentinel/datasource/consul/ConsulDataSource.java 63.76% <0%> (-1.45%) 7% <0%> (ø)
...tinel/slots/block/flow/param/ParamFlowChecker.java 55.4% <0%> (+2.7%) 29% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c33ed81...967151f. Read the comment docs.

@mark8866
Copy link
Contributor Author

Could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=1057

ok

cdfive
cdfive previously approved these changes Sep 23, 2019
Copy link
Collaborator

@cdfive cdfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit c505ca8 into alibaba:master Sep 23, 2019
@sczyh30
Copy link
Member

sczyh30 commented Sep 23, 2019

Thanks for contributing!

@sczyh30 sczyh30 removed the to-review To review label Sep 23, 2019
@sczyh30 sczyh30 added this to the 1.7.0 milestone Sep 23, 2019
@sczyh30 sczyh30 changed the title Feature: 网关规则和自定义api规则动态修改增加对写数据源的支持 Feature: support registering writable data-source for GatewayFlowRule and customized ApiDefinition Nov 7, 2019
hughpearse pushed a commit to hughpearse/Sentinel that referenced this pull request Jun 2, 2021
CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021
…libaba#1177)

* Filter out docker0 when finding a local address

* sweep out bridge interface

Co-authored-by: yuanyuan.xia <yuanyuan.xia@envisioncn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/gateway-flow-control Issues or PRs related to API gateway flow control

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support registering writable data-source for GatewayFlowRule and customized ApiDefinition

5 participants