Skip to content

Add concrete exception message in AsyncEntry#cleanCurrentEntryInLocal #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sczyh30 merged 1 commit into from
Sep 19, 2019
Merged

Add concrete exception message in AsyncEntry#cleanCurrentEntryInLocal #1047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sentinel-core/src/main/java/com/alibaba/csp/sentinel/AsyncEntry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ void cleanCurrentEntryInLocal() {
((CtEntry)parent).child = null;
}
} else {
throw new IllegalStateException("Bad async context state");
String curEntryName = curEntry == null ? "none"
: curEntry.resourceWrapper.getName() + "@" + curEntry.hashCode();
String msg = String.format("Bad async context state, expected entry: %s, but actual: %s",
getResourceWrapper().getName() + "@" + hashCode(), curEntryName);
throw new IllegalStateException(msg);
}
}
}
Expand All @@ -74,7 +78,8 @@ void initAsyncContext() {
.setOrigin(context.getOrigin())
.setCurEntry(this);
} else {
RecordLog.warn("[AsyncEntry] Duplicate initialize of async context for entry: " + resourceWrapper.getName());
RecordLog.warn(
"[AsyncEntry] Duplicate initialize of async context for entry: " + resourceWrapper.getName());
}
}

Expand Down