Skip to content

CommandCenter providers stop method but we can not get instance and invoke it #345

@fangjian0423

Description

@fangjian0423

Issue Description

Spring Boot expose /shutdown Endpoint to shutdown Application. Sentinel-Starter includes sentinel-transport-simple-http module and this module using SPI to trigger SimpleHttpCommandCenter.

After invoke /shutdown endpoint, the process will not exit because the ServerSocket created in SimpleHttpCommandCenter is alive.

So I can invoke CommandCenter#stop to shutdown ThreadPool if I can get CommandCenter instance.

Type: feature request

Describe what feature you want

The single CommandCenter in CommandCenterInitFunc maybe should be hold in some where.

So we can get it and invoke CommandCenter#stop at any time.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomerskind/enhancementCategory issues or prs related to enhancement.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions