Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallelization for standalone mode with NCCL #487

Merged
merged 27 commits into from
Mar 13, 2023
Merged

Parallelization for standalone mode with NCCL #487

merged 27 commits into from
Mar 13, 2023

Conversation

pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented Jan 9, 2023

No description provided.

@pan-x-c pan-x-c changed the title [WIP]Parallelization for standalone mode with NCCL Parallelization for standalone mode with NCCL Mar 9, 2023
@xieyxclack xieyxclack self-requested a review March 13, 2023 04:05
@xieyxclack xieyxclack added the enhancement New feature or request label Mar 13, 2023
xieyxclack
xieyxclack reviewed Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@xieyxclack xieyxclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Some minor suggestions are listed below

federatedscope/main.py Outdated Show resolved Hide resolved
federatedscope/core/workers/server.py Outdated Show resolved Hide resolved
federatedscope/autotune/utils.py Outdated Show resolved Hide resolved
federatedscope/core/auxiliaries/runner_builder.py Outdated Show resolved Hide resolved
federatedscope/core/trainers/torch_trainer.py Outdated Show resolved Hide resolved
federatedscope/core/auxiliaries/parallel_runner.py Outdated Show resolved Hide resolved
@xieyxclack
Copy link
Collaborator

BTW, maybe we can also support parallelization when msg_type = 'evaluation'

xieyxclack
xieyxclack approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@xieyxclack xieyxclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieyxclack xieyxclack merged commit c776b99 into alibaba:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xieyxclack xieyxclack xieyxclack approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pan-x-c @xieyxclack