Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several bugs #461

Merged
merged 5 commits into from
Dec 6, 2022
Merged

Fix several bugs #461

merged 5 commits into from
Dec 6, 2022

Conversation

rayrayraykk
Copy link
Collaborator

  1. Fix conflicts comments in the early stop
  2. Allow specifying respective data transformations for different splits in torchvision
  3. Avoid using list of datasets which will cause the transform functions to fail.

@rayrayraykk rayrayraykk added the bug Something isn't working label Dec 6, 2022
@rayrayraykk rayrayraykk modified the milestone: 460 Dec 6, 2022
This was linked to issues Dec 6, 2022
Confusing range of patience #456
Closed
To allow specifying respective data transformations for different splits #458
Closed
Is transformation of data ignored? #460
Closed
A Question on Dependencies #455
Closed
joneswong
joneswong previously approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@joneswong joneswong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We shall make the train/val/test split translation more general in the future.

joneswong
joneswong approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@joneswong joneswong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks better! Now the "merge data" procedure is clear.

@joneswong joneswong merged commit 429bcc4 into alibaba:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joneswong joneswong joneswong approved these changes

@yxdyc yxdyc Awaiting requested review from yxdyc

Assignees

@joneswong joneswong

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@rayrayraykk @joneswong