re-organize aggregators #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavdGao
reviewed
Aug 8, 2022
| @@ -10,7 +10,7 @@ def get_aggregator(method, model=None, device=None, online=False, config=None): | |||
| from federatedscope.cross_backends import FedAvgAggregator | |||
| return FedAvgAggregator(model=model, device=device) | |||
| else: | |||
| from federatedscope.core.aggregator import ClientsAvgAggregator, \ | |||
| from federatedscope.core.aggregators import ClientsAvgAggregator, \ | |||
There was a problem hiding this comment.
@xieyxclack It seems like more than one argument will influence the type of aggregator, maybe we should determine the final type of aggregator and resolve the potential conflicts before Fedrunner.run(), so that only one argument aggregator.type is enough.
Schichael
pushed a commit
to Schichael/FederatedScope_thesis
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.