[bug_fix] fix call_link_level_trainer() and call_node_level_trainer() #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for your PR, we ask that you sign our Contributor License Agreement before we can accept your contribution. |
… raising ValueError when trainer_type doesn't match
ahn1340
force-pushed
the
fix_gfl_trainer_builder
branch
from
07efaa3 to
c34117d
Compare
|
Thanks for the reply. I have signed the CLA now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
call_link_level_trainer()andcall_node_level_trainer()raisingValueErrorwhentrainer_typedoesn't match. When a custom trainer is registered, the above functions should returnNoneinstead of raising the error, so thattrainer_buildercan properly get the custom trainer.