feat: support ssr #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eternalsky
requested changes
Mar 6, 2025
| @@ -374,7 +374,7 @@ const Overlay = React.forwardRef<HTMLDivElement, OverlayProps>((props, ref) => { | |||
| // - react17 中，如果弹窗 mousedown 阻止了 e.stopPropagation(), 那么 document 就不会监听到事件，因为事件冒泡到挂载节点 rootElement 就中断了。 | |||
| // - https://reactjs.org/blog/2020/08/10/react-v17-rc.html#changes-to-event-delegation | |||
| useListener( | |||
| document, | |||
| typeof document !== 'undefined' ? document : null, | |||
There was a problem hiding this comment.
useListener 监听的对象是 null 是否还有意义？是否更合理的方式应该是没有 document 的情况下就不监听了
There was a problem hiding this comment.
没有的情况在useListener 的具体实现里已经存在了，这里不能动态的设置hooks方法吧，react的hooks按顺序存储，不能没有document的情况下就不执行吧？
eternalsky
approved these changes
Mar 6, 2025
| @@ -374,7 +374,7 @@ const Overlay = React.forwardRef<HTMLDivElement, OverlayProps>((props, ref) => { | |||
| // - react17 中，如果弹窗 mousedown 阻止了 e.stopPropagation(), 那么 document 就不会监听到事件，因为事件冒泡到挂载节点 rootElement 就中断了。 | |||
| // - https://reactjs.org/blog/2020/08/10/react-v17-rc.html#changes-to-event-delegation | |||
| useListener( | |||
| document, | |||
| typeof document !== 'undefined' ? document : null, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复SSR下使用组件报错的问题