Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tag): close button not showing in select when text too long #443

Merged
merged 1 commit into from
Mar 13, 2019
Merged

fix(Tag): close button not showing in select when text too long #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(Tag): close button not showing in select when text too long
  • Loading branch information
@jdkahn
jdkahn committed Mar 13, 2019
commit fd341f8cc2cec85bfb4015f2671b78163a99ba69
12 changes: 12 additions & 0 deletions src/tag/main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,18 @@
&tag-closable {
position: relative;

&.#{$css-prefix}tag-large > .#{$css-prefix}tag-body {
max-width: calc(100% - #{$tag-size-l-height});
}

&.#{$css-prefix}tag-medium > .#{$css-prefix}tag-body {
max-width: calc(100% - #{$tag-size-m-height});
}

&.#{$css-prefix}tag-small > .#{$css-prefix}tag-body {
max-width: calc(100% - #{$tag-size-s-height});
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is -tag-large left?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wasn't necessary for select, since it doesn't use large tags, but i can add it because we don't know if it will need in the future

> .#{$css-prefix}tag-close-btn {
display: inline-block;
vertical-align: middle;
Expand Down
2 changes: 1 addition & 1 deletion src/tag/scss/mixin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
line-height: $height - $borderWidth * 2;
font-size: 0;

$_marginLeft: $height / 4 - 1px;
$_marginLeft: $iconSize;

> .#{$css-prefix}tag-body {
font-size: $fontSize;
Expand Down