Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): dialog height can be number #3807

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

guoyunhe
Copy link
Contributor

让 TypeScript 类型匹配 PropTypes

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #3807 (25ed865) into master (ff7bb16) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3807   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files         303      303           
  Lines       17833    17833           
  Branches     5375     5375           
=======================================
  Hits        16152    16152           
  Misses       1661     1661           
  Partials       20       20           
Impacted Files Coverage Δ
src/dialog/dialog.jsx 93.20% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7bb16...25ed865. Read the comment docs.

@lakerswgq
Copy link
Contributor

propTypes 还是 string,可以一起改了

@guoyunhe
Copy link
Contributor Author

propTypes 还是 string,可以一起改了

改了

@lakerswgq lakerswgq merged commit 174a971 into alibaba-fusion:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants