fix(Select): optimize controlled highlightKey question, close #3795 #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3798 +/- ##
==========================================
- Coverage 90.59% 90.59% -0.01%
==========================================
Files 303 303
Lines 17819 17823 +4
Branches 5369 5372 +3
==========================================
+ Hits 16143 16146 +3
Misses 1657 1657
- Partials 19 20 +1
Continue to review full report at Codecov.
|
bindoon
reviewed
Mar 16, 2022
src/select/select.jsx
Outdated
| highlightKey: nextProps.value, | ||
| }); | ||
| } | ||
|
|
||
| if ('value' in nextProps && nextProps.value !== prevState.value) { | ||
| Object.assign(state, { |
There was a problem hiding this comment.
挪到这里来，并且限制下 single 单选模式才赋值。（多选模式value是数组）
bindoon
approved these changes
Mar 16, 2022
bindoon
pushed a commit
that referenced
this pull request
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.