fix(NumberPicker): repair numberPicker log string, close #3768 #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #3769 +/- ##
=======================================
Coverage 90.58% 90.58%
=======================================
Files 303 303
Lines 17816 17818 +2
Branches 5381 5382 +1
=======================================
+ Hits 16138 16140 +2
Misses 1659 1659
Partials 19 19
Continue to review full report at Codecov.
|
|
应该控制 onChange 的输出必须是整数 |
|
numberPicker实现代码onChange有数据订正，问题所在是up down的点击 |
bindoon
approved these changes
Mar 1, 2022
src/number-picker/number-picker.jsx
Outdated
| @@ -184,7 +184,7 @@ class NumberPicker extends React.Component { | |||
| } else { | |||
| value = defaultValue; | |||
| } | |||
| value = value === undefined || value === null ? '' : stringMode ? `${value}` : value; | |||
| value = value === undefined || value === null ? 0 : stringMode ? `${value}` : value; | |||
There was a problem hiding this comment.
这个是输入，我们的默认值并不是0，只是点上下按钮的时候从0开始增加。
这里应该控制 onChange 的输出必须是整数
bindoon
pushed a commit
that referenced
this pull request
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.