fix(Select): fix Select with useVirtual when empty dataSource #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 88.02% 88.15% +0.12%
==========================================
Files 253 253
Lines 12370 12372 +2
Branches 3211 3263 +52
==========================================
+ Hits 10889 10906 +17
+ Misses 1474 1460 -14
+ Partials 7 6 -1
Continue to review full report at Codecov.
|
|
It looks all right. |
youluna
pushed a commit
that referenced
this pull request
Jan 15, 2019
* fix(Select): fix Select with useVirtual when empty dataSource
tao1991123
added a commit
that referenced
this pull request
Jan 16, 2019
* upstream-master: test(*): ignore compatible with 0.x fix(Slider): can swipe vertical & width 100% invertical fix(Nav): overflow when icon-only without icon test(Table): edit test cases fix(Tab): extra align middle by default fix(Loading): fix fullscreen in demo - add button as safe node to disable document event handler chore(*): resest version of webpack-dev-server chore(*): Release-1.11.8 docs(ConfigProvider): add docs fix(Nav): icon-only overflow bug fix fix(Radio): button shape hover border covers checked border fix(Form): remove warning while message write in jsx fix(Form): switch aligin while size=large fix(Select): fix Select with useVirtual when empty dataSource (#164) fix(Validate): value can be false fix(Nav): can't config nav group label font size/height Update License fix(CascaderSelect): value type not equal dataSource value fix(Timeline): timline-item warning has function type prop # Conflicts: # src/nav/main.scss
youluna
pushed a commit
that referenced
this pull request
Jan 23, 2019
* fix(Select): fix Select with useVirtual when empty dataSource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select 组件开启virtual和showSearch之后，当filter出空dataSource时抛异常。
简单判断children.length为0，关闭virtual