Skip to content

Issue #39 Fixed error: Authentication login() has no null checks #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
M-Sidhu25 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue #39 Fixed error: Authentication login() has no null checks #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50dd30f
#56 calculateMean() no longer crashes on empty list
M-Sidhu25 Oct 27, 2025
a2b5e23
#39 Fixed error: Authentication login() has no null checks
M-Sidhu25 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/java/Authentication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ public void registerUser(String username, String password) {
// BUG: No null checks - will throw NullPointerException
// BUG: Plain text password comparison - SECURITY ISSUE
public boolean login(String username, String password) {
if (username == null || password == null) {
return false;
}
String storedPassword = users.get(username);
boolean isValid = storedPassword.equals(password);

Expand Down
5 changes: 4 additions & 1 deletion src/java/DataProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ public void wirteFile(String filepath, List<String> data) throws IOException {
// BUG: Returns 0 for empty list without indication
public double calculateMean(List<Double> numbers) {
if (numbers.isEmpty()) {
return 0;
throw new ArithmeticException("List is empty");
}
if (numbers.size() == 0) {
throw new ArithmeticException("List is empty");
}
double sum = 0;
for (double num : numbers) {
Expand Down