-
Notifications
You must be signed in to change notification settings - Fork 70
fix: add catch for get conn exception #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fengmk2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
先不合并,我需要先将 auto release 修复。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds error handling to prevent unhandled promise rejections when a connection timeout occurs. The change ensures that if a connection promise rejects after a timeout has already been thrown, the rejection is caught and silently ignored.
Key Changes
- Added a
.catch()handler to the connection promise in the timeout error path to prevent unhandled rejection errors
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
🎉 This PR is included in version 6.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.