-
-
Notifications
You must be signed in to change notification settings - Fork 360
Adding PID controller Chapter. #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 8 commits
37b0068
874abf5
17b7226
aaa8c40
7a1ad44
4c0aa45
6bdd7ad
28c3f5c
182f4bf
6a8b5e1
a0608f3
45e66ef
570b7b1
2d2be13
aadf198
9a7849e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| #include <stdio.h> | ||
|
|
||
| struct pid_context { | ||
| double kp; | ||
| double ki; | ||
| double kd; | ||
| double setpoint; | ||
| double last_error; | ||
| double integral; | ||
| double dt; // Normally you calculate the change in time. | ||
| }; | ||
|
|
||
| struct pid_context get_pid(double setpoint, double dt, double kp, double ki, | ||
| double kd) { | ||
|
|
||
| struct pid_context ctx = {0}; | ||
| ctx.setpoint = setpoint; | ||
| ctx.dt = dt; | ||
| ctx.kp = kp; | ||
| ctx.ki = ki; | ||
| ctx.kd = kd; | ||
|
|
||
| return ctx; | ||
| } | ||
|
|
||
| double pid_calculate(struct pid_context ctx, double input) { | ||
| // Here you would calculate the time elapsed. | ||
| double error = ctx.setpoint - input; | ||
| ctx.integral += error * ctx.dt; | ||
| double derivative = (error - ctx.last_error) / ctx.dt; | ||
| ctx.last_error = error; | ||
|
|
||
| return ctx.kp * error + ctx.ki * ctx.integral + ctx.kd * derivative; | ||
| } | ||
|
|
||
| int main() { | ||
| struct pid_context ctx = get_pid(1.0, 0.01, 1.2, 1.0, 0.001); | ||
| double input = 0.0; | ||
|
|
||
| for (int i = 0; i < 100; ++i) { | ||
| input += pid_calculate(ctx, input); | ||
| printf("%g\n", input); | ||
| } | ||
|
|
||
| return 0; | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,86 @@ | ||||||||||
| # Proportional-Integral-Derivative Controller | ||||||||||
| Written by Gathros | ||||||||||
|
||||||||||
|
|
||||||||||
Gathros marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||
| The Proportional-Integral-Derivative controller (PID controller) is a control loop feedback mechanism, used for continuously modulated control. | ||||||||||
| The PID controller is comprised of three parts: proportional controller, integral controller, and derivative controller. | ||||||||||
|
||||||||||
|
|
||||||||||
| Before we get into how a PID controller works, we need a good example to explain things. | ||||||||||
| Imagine you are making a self-driving RC car that drives on a line, how could we keep the car on track if it moves with a constant speed? | ||||||||||
|
||||||||||
|
|
||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe add a sentence here like:
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I prefer introducing it over time, to make it easier to follow.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My argument was that it was not followable without a transitional sentence. |
||||||||||
| ### Proportional Controller | ||||||||||
|
|
||||||||||
| Imagine our RC car is moving too far to the right, in this case it makes sense to turn left. | ||||||||||
|
||||||||||
| Since there are a range of angles you can turn the wheel, you should turn proportional to the distance from the line. | ||||||||||
|
||||||||||
| Since there are a range of angles you can turn the wheel, you should turn proportional to the distance from the line. | |
| Since there are a range of angles you could turn the wheel by, it is unclear what strategy would work best to return the RC car to the line; however, it is clear that if the angle chosen is proportional to the distance from the line, the car will always be moving towards it. |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need a comma at the end
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Where $K_{p}$ is a constant and $e(t)$ is the current distance from the line, which is called the error. | |
| Where $$K_{p}$$ is an arbitrary constant and $$e(t)$$ is the current distance from the line, which is called the error. |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The performance of the controller improves with larger $K_{p}$; | |
| The performance of the controller improves with larger $$K_{p}$$; |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if $K_{p}$ is too high then when the error is too high, the system becomes unstable. | |
| however, if $$K_{p}$$ and $$e(t)$$ are too high then the system becomes unstable. |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have an animation to show these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a note should be made here that the car's motion can be completely corrected with the Proportional controller, but it has the problem of overshooting a lot, thus additional controllers are necessary to maintain proper control of the car.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this was not addressed.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the P controller really provide an oscillation? It seems like just an overshooting, right? If that's the case, it makes more sense to say "dampen this motion" then "dampen these oscillations"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P controllers may over shoot then it will start to oscillate around the track. So you're dampening this oscillation not the motion of the car.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me how we can model the error in the P controller as an oscillation. Again, an animation or some depiction could help here.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| One way to solve this is to make the rc car resistant to sudden changes of error. | |
| One way to do this is to make the RC car resistant to sudden changes of error. |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comma at the end here either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are de and dt? Maybe note that this is something like a derivative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a derivative.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Where $K_{d}$ is a constant. | |
| If $K_{d}$ is too high then the system is overdamped, i.e. the car takes too long to get back on track. | |
| Where $$K_{d}$$ is a constant. | |
| If $$K_{d}$$ is too high then the system is overdamped, i.e. the car takes too long to get back on track. |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| If it's too low the system is underdamped, i.e. the car oscillates around the line. | |
| If it's too low, the system is underdamped, i.e. the car oscillates around the line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we show an animation with all three of these side-by-side?
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep the car on the line
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What errors are referring to here? I think this sentence needs to be reworked and made more clear.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, no comma (I think)
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\uptau doesn't seem to exist in mathjax, can we use tau?
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, a side-by-side animation would do well here
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again no comma (I think)
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| To use a PID controller, you need to tune it by setting the constants, $K_{p}$, $K_{i}$, and $K_{d}$. | |
| To use a PID controller, you need to tune it by setting the constants, $$K_{p}$$, $$K_{i}$$, and $$K_{d}$$. |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will these be covered? If so, leave a note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They aren't algorithms it's just done by hand so I don't imagine there being a chapter on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, then for completeness we might want to differentiate these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are mentioned, they should be described. You can add a simple list with all of them and how they are differentiated from each other.
It might be worth adding a separate heading for tuning and discussing these in-turn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not link to the wiki page https://en.wikipedia.org/wiki/PID_controller#Overview_of_tuning_methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, it would be nice to have citations for all of these with bibtex-cite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you cite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put the appropriate bibtex citation in the literature.bib file at the start of the directory, then put {{ "ct1965" | cite } where you want to cite it and add a
### Bibliography
{% references %} {% endreferences %}
at the bottom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, Thanks.
leios marked this conversation as resolved.
Show resolved
Hide resolved
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## The Algorithm | |
| ## Putting it all together |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need some more information here or in the code because it's unclear. What does setpoint mean? "where the numbers represent the center of the lane" is really vague. What does that mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what you want me to write there, I can't make it more clear.
Uh oh!
There was an error while loading. Please reload this page.