Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: orchestration support; fixing tealscript base contract (number -> uint64) #10

Merged
merged 6 commits into from
Mar 27, 2024
Merged

feat: orchestration support; fixing tealscript base contract (number -> uint64) #10

merged 6 commits into from
Mar 27, 2024

Conversation

aorumbayev
Copy link
Collaborator

@aorumbayev aorumbayev commented Mar 18, 2024 •
edited
Loading

Proposed changes

  • Bare minimum run command definition + tweaks in base contract to support e2e flow when used against react in fullstack template
  • Fixing base contract to use uint64 instead of number; adding hello abi method to support e2e flow when used against react in fullstack template

Further notes

@aorumbayev aorumbayev requested review from joe-p and nullun March 18, 2024 10:03
@joe-p joe-p force-pushed the feat/orchestration branch from 6475754 to 7f391e4 Compare March 19, 2024 17:49
@joe-p
Copy link
Contributor

joe-p commented Mar 19, 2024

I noticed there are duplicate contracts {{ project_name }}.algo.ts.jinja and {{ contract_name }}.algo.ts.jinja

@aorumbayev
Copy link
Collaborator Author

I noticed there are duplicate contracts {{ project_name }}.algo.ts.jinja and {{ contract_name }}.algo.ts.jinja

good catch, should be removed now, added extra test case for hello method

@aorumbayev aorumbayev merged commit 0501eec into master Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nullun nullun nullun approved these changes

@joe-p joe-p Awaiting requested review from joe-p

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aorumbayev @joe-p @nullun