feat: adding app version and reject version support #440
+467
−250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilcampbell
force-pushed
the
feat/access-list
branch
from
a60e629 to
abe4778
Compare
neilcampbell
force-pushed
the
feat/app-version
branch
from
c54f2a0 to
a0bd542
Compare
neilcampbell
force-pushed
the
feat/access-list
branch
from
abe4778 to
7f78528
Compare
neilcampbell
force-pushed
the
feat/app-version
branch
from
a0bd542 to
a068876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is waiting for a new version of algosdk which fixes issues with rejectVersion field msgpack encoding. (See algorand/js-algorand-sdk#1013)
Development Notes
Exploratory tested by creating a test which creates and updates a mutable app using the AppDeployer.
Ledger testing was performed on localnet using goal, which showed that the rejectVersion field is included in the signed message