feat!: replace AlgorandClientInterface with AlgorandClient #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the discussion in #365 for context. Essentially by continuing to use the Interface any additional feature to AlgorandClient becomes a breaking change. The only reason for using the interface in the first place was for a rollup error, but this was a false positive and can be fixed by using the type import as shown in this commit
joe-p
added a commit
to algorandfoundation/algokit-client-generator-ts
that referenced
this pull request
Mar 21, 2025
Replicates the changes made in algorandfoundation/algokit-utils-ts#387
This was referenced Mar 24, 2025
joe-p
added a commit
to algorandfoundation/algokit-client-generator-ts
that referenced
this pull request
Mar 25, 2025
Replicates the changes made in algorandfoundation/algokit-utils-ts#387
joe-p
added a commit
to algorandfoundation/algokit-client-generator-ts
that referenced
this pull request
Mar 25, 2025
Replicates the changes made in algorandfoundation/algokit-utils-ts#387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion in
#365 for context. Essentially by continuing to use the Interface any additional feature to AlgorandClient becomes a breaking change. The only reason for using the interface in the first place was for a rollup error, but this was a false positive and can be fixed by using the type import as shown in this commit
This PR should stay in draft until we can measure the impact to depdendent libraries and come up with a release strategy as we approach Algokit v3