- 
                Notifications
    
You must be signed in to change notification settings  - Fork 12
 
feat: migration to uv and initial structure setup for sub packages from core #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1,39 @@ | |||
| root = true | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is primarily to prevent from auto formatting of yaml files in github workflows on vscode
416da9f    to
    a0c330e      
    Compare
  
    a0c330e    to
    8a38417      
    Compare
  
    | module = ["msgpack", "msgpack.*"] | ||
| ignore_missing_imports = true | ||
| 
               | 
          ||
| [[tool.mypy.overrides]] | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these excluded because they are autogenerated? Ideally they would still type check properly, perhaps we can just ignore a smaller subset of errors if there are certain tricky ones?
…les from packages to src
This allows it to be included in the uv cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a question
| cicd = [ | ||
| "algokit>=2.9.1", | ||
| ] | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this dependency? Why is it needed for CICD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its the algokit cli package, by including it as part of the dependency group it can be included in the uv cache for this action. See this commit
Proposed Changes
decouplingbranch as a main branch for the duration of delivery of algosdk decoupling