Skip to content

chore: flatten the ffi transaction struct header #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

neilcampbell
Copy link
Collaborator

@neilcampbell neilcampbell commented May 3, 2025

This PR keeps the rust Transaction struct the same, however flattens the FFI transaction struct.

Note: This PR is currently based against the object-mother branch, however will be re-targeted to main once that branch has been merged.

@neilcampbell neilcampbell requested review from lempira and joe-p May 3, 2025 17:35
Copy link
Collaborator

@joe-p joe-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming no problems arise with upstream PR

@neilcampbell neilcampbell force-pushed the feat/object-mother branch from 3dfcca6 to 9882afd Compare May 5, 2025 06:24
Base automatically changed from feat/object-mother to main May 5, 2025 06:34
@neilcampbell neilcampbell force-pushed the fix/ffi-txn-header branch from 41f4e67 to f42bf87 Compare May 5, 2025 07:06
@neilcampbell neilcampbell merged commit 6ef7dcb into main May 5, 2025
14 checks passed
@neilcampbell neilcampbell deleted the fix/ffi-txn-header branch May 5, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants