Skip to content

feat: Add transaction builders and test object mother abstractions #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 5, 2025

Conversation

neilcampbell
Copy link
Collaborator

@neilcampbell neilcampbell commented May 2, 2025

  • Added builders for creating payment and asset transfer transactions
  • Added transaction, transaction header, address, and test data object mothers
  • Test data json is generated when running cargo build on algokit_transaction_ffi
  • Renamed PayTransactionFields to PayTransactionFields
  • Renamed pay_fields to payment in FFI Transaction struct
  • Renamed asset_transfer_fields to asset_transfer in FFI Transaction struct

@neilcampbell neilcampbell requested review from lempira and joe-p May 2, 2025 15:32
Copy link
Collaborator

@joe-p joe-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will need to resolve merge conflicts with CI

One common thing I noticed is that there were some diffs caused by formatting for Rust, YAML, and TS so we should probably align on what formatting tools we want to use and ensure they are setup properly in the repo.

Also there's an opportunity for us to add some abstraction in the builder (i.e. mainnet and testnet functions) but I don't think we need to focus on that now.

@neilcampbell neilcampbell force-pushed the feat/object-mother branch from 3dfcca6 to 9882afd Compare May 5, 2025 06:24
@neilcampbell neilcampbell merged commit 43d8ba6 into main May 5, 2025
14 checks passed
@neilcampbell neilcampbell deleted the feat/object-mother branch May 5, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants