-
Notifications
You must be signed in to change notification settings - Fork 7
ci(python): use re-usable python uniffi CI/CD workflow #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b0591fc to
840955c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a reusable CI/CD workflow for Python Uniffi packages, enabling automated version bumping, artifact management, and semantic releases. Key changes include:
- A new semantic-release configuration in release.config.mjs.
- Enhancements to the python_uniffi_ci_cd workflow with version bumping, artifact upload, and job dependencies.
- A unified CI/CD workflow (ci_cd.yml) that leverages the new python_uniffi_ci_cd workflow.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/python/algokit_transact/release.config.mjs | Adds semantic-release configuration for Python packages. |
| .github/workflows/python_uniffi_ci_cd.yml | Refactors CI/CD workflow with version bump and artifact upload. |
| .github/workflows/ci_cd.yml | Introduces a higher-level workflow that calls the Python CI/CD job. |
Comments suppressed due to low confidence (1)
.github/workflows/python_uniffi_ci_cd.yml:96
- Using the 'master' branch for the rust-toolchain action may lead to unexpected issues due to changes in the action. Pinning to a specific, stable version would improve build stability.
uses: dtolnay/rust-toolchain@master
47035c8 to
8f09222
Compare
8f09222 to
585b9a9
Compare
5ff4080 to
419b107
Compare
neilcampbell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
First step to getting full CD for Python with uniffi packages.
Example releases can be seen here: https://github.com/joe-p/algokit-core/releases
To-do in later PR: