Skip to content

Conversation

@joe-p
Copy link
Collaborator

@joe-p joe-p commented Apr 28, 2025

First step to getting full CD for Python with uniffi packages.

Example releases can be seen here: https://github.com/joe-p/algokit-core/releases

To-do in later PR:

  • PyPi release
  • TypeScript CI/CD
  • Windows 11 ARM support

@joe-p joe-p force-pushed the ci/py_uniffi_ci_cd branch from b0591fc to 840955c Compare April 28, 2025 14:07
@joe-p joe-p requested a review from Copilot April 28, 2025 14:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a reusable CI/CD workflow for Python Uniffi packages, enabling automated version bumping, artifact management, and semantic releases. Key changes include:

  • A new semantic-release configuration in release.config.mjs.
  • Enhancements to the python_uniffi_ci_cd workflow with version bumping, artifact upload, and job dependencies.
  • A unified CI/CD workflow (ci_cd.yml) that leverages the new python_uniffi_ci_cd workflow.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/python/algokit_transact/release.config.mjs Adds semantic-release configuration for Python packages.
.github/workflows/python_uniffi_ci_cd.yml Refactors CI/CD workflow with version bump and artifact upload.
.github/workflows/ci_cd.yml Introduces a higher-level workflow that calls the Python CI/CD job.
Comments suppressed due to low confidence (1)

.github/workflows/python_uniffi_ci_cd.yml:96

  • Using the 'master' branch for the rust-toolchain action may lead to unexpected issues due to changes in the action. Pinning to a specific, stable version would improve build stability.
uses: dtolnay/rust-toolchain@master

@joe-p joe-p requested a review from neilcampbell April 28, 2025 14:13
@joe-p joe-p force-pushed the ci/py_uniffi_ci_cd branch from 47035c8 to 8f09222 Compare April 28, 2025 16:36
@joe-p joe-p force-pushed the ci/py_uniffi_ci_cd branch from 8f09222 to 585b9a9 Compare April 28, 2025 18:04
@joe-p joe-p marked this pull request as draft April 28, 2025 20:16
@joe-p joe-p marked this pull request as ready for review April 28, 2025 20:27
@joe-p joe-p force-pushed the ci/py_uniffi_ci_cd branch from 5ff4080 to 419b107 Compare April 28, 2025 20:40
Copy link
Collaborator

@neilcampbell neilcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joe-p joe-p merged commit 5b0dfe2 into main Apr 29, 2025
2 checks passed
@joe-p joe-p deleted the ci/py_uniffi_ci_cd branch April 30, 2025 17:55
@engineering-ci
Copy link
Contributor

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@engineering-ci
Copy link
Contributor

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@engineering-ci
Copy link
Contributor

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@engineering-ci
Copy link
Contributor

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants