Adding ARCs 0004 to 0011 and updating ARC 0001 #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding stxn field following comment algorandfoundation#1 (comment) from @DanBurton
Following comment algorandfoundation#1 (comment) from @DanBurton This PR is to be dicussed. `signTxns` is indeed more logical. `signTxn` can still exist and be mapped to `signTxns` for backward compatibility. So I don't think this should create too many issues but please raise your voice if it does.
…arcs-0004-to-0011
From algorandfoundation#8 with the following changes: * use of `genesisID`/`genesisHash` instead of `network` for `enable` * enforce main networks' hashes from genesisID * allow `enable` to return no account for just access to blockchain * support of list of group of transactions in posting * clarify error handling in many cases * add security considerations in many places * add optional `signTxns` and `postTxns` to wallet standard * clarify requirements for confirmation when posting transactions * use `BaseHTTPClient` from algorand/js-algorand-sdk#477 for `getAlgodv2Client` and `getIndexerClient` * other minor changes Main points to discuss: * splitting the error standards out of ARC-0001 and make it a living standard * allow optional argument to post without waiting for confirmation (dangerous)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #8
with the following changes:
genesisID/genesisHashinstead ofnetworkforenableenableto return no account for just access to blockchainsignTxnsandpostTxnsto wallet standardBaseHTTPClientfrom Enabling a custom client for Algod and Indexer algorand/js-algorand-sdk#477for
getAlgodv2ClientandgetIndexerClientInclude #29 and #28
Main points to discuss: