-
Notifications
You must be signed in to change notification settings - Fork 132
Prep CHANGELOG for v0.14.0 #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ahangsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@ahangsu Leaving responses inline, let me know if it helps. I can speak live if helpful.
Thanks for pointing it out - I added it.
|
Yes, I was trying to suggest that, #264 is containing all the ABI support we have at hand, so it might be a better suit, but your suggestion also makes sense to me, that #170 itself has a sufficient size to be standalone. I wonder if we can add a line for #264 to mention all other ABI related support, for I hope folks to recognize other ABI support out there? I don't feel too strong on this one, feel free to accept or reject. |
@ahangsu I'm open to suggestions. I felt providing more explanation ends up being too verbose and less effective than the user guide. So, I opted for a terse summary. |
Got it got it. I have no push back on this one. I think it is okay to keep as is then. |
jasonpaulos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise things look good
Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
Provides
CHANGELOG.mdupdates for v0.14.0.