Skip to content

Conversation

@michaeldiamant
Copy link
Contributor

Provides CHANGELOG.md updates for v0.14.0.

@michaeldiamant michaeldiamant marked this pull request as ready for review July 21, 2022 14:04
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we consider adding these PR in:

  • #359 for document fix from community side
  • #170 or #264, feels more like a full set of ABI support we present?

@michaeldiamant
Copy link
Contributor Author

@ahangsu Leaving responses inline, let me know if it helps. I can speak live if helpful.

#359 for document fix from community side

Thanks for pointing it out - I added it.

#170 or #264, feels more like a full set of ABI support we present?

@ahangsu
Copy link
Contributor

ahangsu commented Jul 22, 2022

Are you suggesting that since #170 is included in #264, calling out #170 is not needed?

Yes, I was trying to suggest that, #264 is containing all the ABI support we have at hand, so it might be a better suit, but your suggestion also makes sense to me, that #170 itself has a sufficient size to be standalone.

I wonder if we can add a line for #264 to mention all other ABI related support, for I hope folks to recognize other ABI support out there? I don't feel too strong on this one, feel free to accept or reject.

@michaeldiamant
Copy link
Contributor Author

to recognize other ABI support out there?

@ahangsu I'm open to suggestions. I felt providing more explanation ends up being too verbose and less effective than the user guide. So, I opted for a terse summary.

@ahangsu
Copy link
Contributor

ahangsu commented Jul 22, 2022

providing more explanation ends up being too verbose and less effective than the user guide.

Got it got it. I have no push back on this one. I think it is okay to keep as is then.

Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise things look good

Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
@michaeldiamant michaeldiamant merged commit d8b65b7 into master Jul 25, 2022
@michaeldiamant michaeldiamant deleted the v0.14.0-changelog branch July 25, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants