Skip to content

adding byte type hint to DyanamicArray parent class #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barnjamin merged 3 commits into from
May 13, 2022
Merged

adding byte type hint to DyanamicArray parent class #339

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b53c9e
adding byte type hint to DyanamicArray parent class
barnjamin May 12, 2022
59e53bb
appease mypy
barnjamin May 13, 2022
fb42e58
specify Byte in set method instead of T
barnjamin May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions pyteal/ast/abi/string.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from typing import Union, TypeVar, Sequence
from typing import Union, TypeVar, Sequence, cast
from collections.abc import Sequence as CollectionSequence

from pyteal.ast.abi.uint import Byte
from pyteal.ast.abi.type import ComputedValue, BaseType
from pyteal.ast.abi.array_dynamic import DynamicArray, DynamicArrayTypeSpec
from pyteal.ast.abi.uint import ByteTypeSpec, Uint16TypeSpec
Expand Down Expand Up @@ -39,7 +40,7 @@ def __eq__(self, other: object) -> bool:
StringTypeSpec.__module__ = "pyteal"


class String(DynamicArray):
class String(DynamicArray[Byte]):
def __init__(self) -> None:
super().__init__(StringTypeSpec())

Expand All @@ -54,9 +55,9 @@ def get(self) -> Expr:
def set(
self,
value: Union[
Sequence[T],
DynamicArray[T],
ComputedValue[DynamicArray[T]],
Sequence[Byte],
DynamicArray[Byte],
ComputedValue[DynamicArray[Byte]],
"String",
str,
bytes,
Expand Down Expand Up @@ -86,7 +87,7 @@ def set(
case Expr():
return self.stored_value.store(encoded_string(value))
case CollectionSequence():
return super().set(value)
return super().set(cast(Sequence[Byte], value))

raise TealInputError(
f"Got {type(value)}, expected DynamicArray, ComputedValue, String, str, bytes, Expr"
Expand Down