Blackbox Decorator #297
Merged
Blackbox Decorator #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
approved these changes
Apr 26, 2022
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
I have minor comments but I'll save those for the parent PR. On the whole this looks good
michaeldiamant
approved these changes
Apr 26, 2022
Contributor
michaeldiamant
left a comment
michaeldiamant
left a comment
There was a problem hiding this comment.
@tzaffi Thanks for trying the approach - it looks like what I had in mind. Provided folks are on-board, then let's roll with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This child PR to #249 implements @michaeldiamant 's suggestion for a new
@Blackboxdecorator.