-
Notifications
You must be signed in to change notification settings - Fork 132
Dynamic Scratch Variables #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ca75dbf
Fresh Start: Dynamic Scratch Variables
21ea026
TDD. Stuck at dynamic_scratch.py: line 58
ccd3a8b
Next, get past dynamic_scratch.py: line 66 - need an index()
91e10e4
compiler doesn't recognize DynamicSlot - and it shouldn't have to
26ce3af
fixed load but store still reaches compiler
b395734
pass the TDD and even a more ambitions dynamic_scratch_2 case
becd971
fix incorrect comment, and make the wilt comment into a real test
c1aaa45
pass mypy... but did we cast too much?
8e9659e
more assertive and precise type casting
126ac76
new e2e circle test
1159ba6
ready for review... but it's also time for unit tests
0e5bccc
fix test logic error, plus better comments in wilt TEAL
a0a351d
unnecessary todo - given successful e2e tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alphabetize and add
DynamicSlot