-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev Tools: Source map decoder #353
Conversation
Nice, I think this will work nicely when the APIs also support the disassemble endpoint (related ticket). We could add some cucumber tests in the testing repo as well to check the translation, but I'm not sure what would be the easiest way to test it (maybe output the VLQ->Int mapping in a unified JSON format?) |
…esting source map to be generated
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
… into src-map-decoder
…line_to_pc even if the result is None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, once Andrew's suggestion is resolved, we should probably ship it?
Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
… into src-map-decoder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@barnjamin Leaving approval with a friendly reminder to revert branch change in run_integration.sh
prior to merging.
The VLQ encoding is a lot to ask folks to implement themselves, lets provide some easier way to get the numeric pc
Lifted from @algochoi https://github.com/algochoi/teal-sourcemap-decoder
@michaeldiamant I think this would need to be implemented across the SDKs assuming we can come up with a good way to expose it.
I'm imagining with the json src_map