New Feature: Add Retry Variables #1370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #1355 Adds retry variables to set retry delay and count as well as unit tests
AlgoStephenAkiki
requested review from
mciccarello,
winder,
Eric-Warehime and
shiqizng
shiqizng
reviewed
Dec 8, 2022
winder
reviewed
Dec 8, 2022
winder
reviewed
Dec 8, 2022
winder
reviewed
Dec 8, 2022
shiqizng
reviewed
Dec 8, 2022
shiqizng
reviewed
Dec 8, 2022
winder
reviewed
Dec 9, 2022
winder
approved these changes
Dec 9, 2022
Codecov Report
@@ Coverage Diff @@
## develop #1370 +/- ##
===========================================
+ Coverage 63.35% 63.41% +0.05%
===========================================
Files 76 76
Lines 10491 10506 +15
===========================================
+ Hits 6647 6662 +15
Misses 3280 3280
Partials 564 564
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1355
Adds retry variables to set retry delay and count as well as unit tests
Summary
Explain the goal of this change and what problem it is solving. Format this cleanly so that it may be used for a commit message, as your changes will be squash-merged.
Test Plan
How did you test these changes? Please provide the exact scenarios you tested in as much detail as possible including commands, output and rationale.