New Feature: Application Boxes in Indexer #1168

tzaffi · 2022-08-09T15:05:11Z

Integration branch where "ready to merge" box-related code will live until go-algorand box code is itself merged.

TODO before merging

Has go-algorand's feature/avm-box been merged?
End-to-end test
- is passing against network that includes boxes
- has been re-pointed to rel-nightly once that job includes boxes
- .circleci/config.yml's CI_E2E_FILENAME has been reverted
Re-point the third_party/go-algorand submodule to
- go-algorand
- a released commit containing boxes

Co-authored-by: Will Winder <wwinder.unh@gmail.com> Co-authored-by: shiqi.zheng@algorand.com <shiqi.zheng@algorand.com> Co-authored-by: Eric Warehime <eric.warehime@gmail.com> Co-authored-by: AlgoStephenAkiki <85183435+AlgoStephenAkiki@users.noreply.github.com> Co-authored-by: John Jannotti <jannotti@gmail.com>

codecov · 2022-08-09T15:19:33Z

Codecov Report

Merging #1168 (acec7c4) into develop (95658bc) will increase coverage by 1.25%.
The diff coverage is 73.46%.

@@             Coverage Diff             @@
##           develop    #1168      +/-   ##
===========================================
+ Coverage    61.11%   62.36%   +1.25%     
===========================================
  Files           52       52              
  Lines         8512     8843     +331     
===========================================
+ Hits          5202     5515     +313     
+ Misses        2848     2827      -21     
- Partials       462      501      +39

Impacted Files	Coverage Δ
api/error_messages.go	`100.00% <ø> (ø)`
api/generated/common/routes.go	`46.51% <ø> (ø)`
api/server.go	`61.84% <ø> (ø)`
idb/dummy/dummy.go	`0.00% <0.00%> (ø)`
idb/idb.go	`69.35% <ø> (ø)`
idb/postgres/internal/encoding/types.go	`66.66% <ø> (ø)`
idb/postgres/internal/writer/util.go	`100.00% <ø> (ø)`
idb/sig_type.go	`64.00% <0.00%> (ø)`
idb/postgres/internal/writer/writer.go	`85.64% <64.00%> (-1.58%)`	⬇️
api/handlers.go	`75.42% <70.73%> (-0.29%)`	⬇️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…tch error #4372)

misc/docker-compose.yml

idb/postgres/postgres_integration_test.go

…emporarily set it to 300

misc/e2elive.py

…ch and temporarily set it to 300" This reverts commit 9303c83.

misc/docker-compose.yml

.circleci/config.yml

…into integration/boxes

…ueDelta and *string

tzaffi

spurious space

.circleci/config.yml

…into integration/boxes

tzaffi added the New Feature label Aug 9, 2022

tzaffi marked this pull request as draft August 9, 2022 15:05

tzaffi changed the title ~~New Feature: Application Boxes~~ New Feature: Application Boxes in Indexer Aug 9, 2022

tzaffi mentioned this pull request Aug 9, 2022

New Feature: Lookup Boxes by app-id + Name and Search Boxes by app-id #1117

Merged

12 tasks

Zeph Grunschlag added 2 commits August 9, 2022 14:42

Update go-algorand submodule (Remove “contact us” from box name misma…

5681adb

…tch error #4372)

Merge branch 'develop' into integration/boxes

ec18e29

tzaffi commented Aug 10, 2022

View reviewed changes

misc/docker-compose.yml Outdated Show resolved Hide resolved

tzaffi commented Aug 10, 2022

View reviewed changes

idb/postgres/postgres_integration_test.go Outdated Show resolved Hide resolved

tzaffi and others added 4 commits August 10, 2022 00:27

errant extra comma in comment

7aa7f2f

re-point submodule to lateast feature/avm-box commit

06ec61a

Merge branch 'develop' into integration/boxes

89283d7

expose max_s3_keys haystack size in firstFromS3's needle search and t…

9303c83

…emporarily set it to 300

tzaffi commented Aug 22, 2022

View reviewed changes

misc/e2elive.py Outdated Show resolved Hide resolved

Zeph Grunschlag added 3 commits August 22, 2022 18:38

Revert "expose max_s3_keys haystack size in firstFromS3's needle sear…

3570a16

…ch and temporarily set it to 300" This reverts commit 9303c83.

point to a newer box inclusive tar ball

2e2b504

Merge branch 'develop' into integration/boxes

ab0208c

tzaffi commented Aug 26, 2022

View reviewed changes

misc/docker-compose.yml Outdated Show resolved Hide resolved

Zeph Grunschlag added 5 commits September 1, 2022 09:23

Merge branch 'develop' into integration/boxes

cd08d66

update go-algorand submodule to feature/avm-box latest

e63df7d

update go.mod/sum to adjust for breakout of avm-abi from go-algorand

f70ed58

Merge branch 'develop' into integration/boxes

ae841ae

temporary: point to E2E test tarball to containing boxes

a759ca5

tzaffi commented Sep 8, 2022

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

Zeph Grunschlag added 5 commits September 13, 2022 09:59

update submodule

be68a93

update submodule

1a8b465

Merge branch 'develop' of github.com:algorand/indexer into develop

5f199ed

Merge branch 'develop' into integration/boxes

4881e51

update submodule

4bdc0a0

Zeph Grunschlag added 13 commits October 3, 2022 14:23

Merge remote-tracking branch 'refs/remotes/origin/integration/boxes' …

a47ce18

…into integration/boxes

regenerate

c065e1e

update submodule

5d5fc5b

Merge branch 'develop' into integration/boxes

193dbc8

latest go-algorand

1eae85f

Merge branch 'develop' into integration/boxes

bba69ef

point to latest e2e tarball with boxes

b72192f

Merge branch 'develop' into integration/boxes

c65dd10

latest go-algorand

239e6d6

following go-algorand changes: KvValueDelta and []byte instead of Val…

ed83375

…ueDelta and *string

test updates

9d93edc

update submodule

3d4b6f0

latest tarball

6deb9b3

tzaffi commented Oct 31, 2022

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

Update .circleci/config.yml

7de386f

Zeph Grunschlag added 7 commits November 1, 2022 10:03

update go-algorand latest from master

8745cf3

pin E2E test to the last rel/nightly

eddb0d0

Merge remote-tracking branch 'refs/remotes/origin/integration/boxes' …

bda577c

…into integration/boxes

update submodule with lint fix

5d1a24c

go mod tidy for latest msgp

21ac00c

once again that sneaky EOL

802bc02

update go-algorand some more - including catchpoint fix

acec7c4

tzaffi merged commit be89f75 into develop Nov 1, 2022

tzaffi deleted the integration/boxes branch November 1, 2022 17:43

algojack mentioned this pull request Nov 2, 2022

FOR REVIEW ONLY: indexer 2.15.0 into master #1309

Merged

winder pushed a commit to winder/indexer that referenced this pull request Nov 27, 2022

New Feature: Application Boxes in Indexer (algorand#1168)

75adc17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

New Feature: Application Boxes in Indexer #1168

New Feature: Application Boxes in Indexer #1168

Uh oh!

tzaffi commented Aug 9, 2022 •

edited

Loading

Uh oh!

codecov bot commented Aug 9, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tzaffi left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

New Feature: Application Boxes in Indexer #1168

New Feature: Application Boxes in Indexer #1168

Uh oh!

Conversation

tzaffi commented Aug 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO before merging

Uh oh!

codecov bot commented Aug 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tzaffi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tzaffi commented Aug 9, 2022 •

edited

Loading

codecov bot commented Aug 9, 2022 •

edited

Loading