Skip to content

config: enable hybrid mode by default #6319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented May 9, 2025

Summary

Set EnableP2PHybridMode to true in config defaults.

Most of the changes are about to make tests work with EnableP2PHybridMode=true. It is either to set PublicAddress and P2PHybridNetAddress (e2e-subs, expect tests) or to override EnableP2PHybridMode back to FALSE value (e2e-go).

Test Plan

Existing tests

@algorandskiy algorandskiy requested review from cce, jannotti and gmalouf May 9, 2025 19:34
@algorandskiy algorandskiy self-assigned this May 9, 2025
Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a user really doesn't want to run p2p, they would edit their config file by hand ahead of upgrade, and set it to false. Then we would respect that change because it's explicit?

gmalouf
gmalouf previously approved these changes May 10, 2025
Copy link
Contributor

@gmalouf gmalouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add an additional algocfg option for running a client with P2P disabled, but otherwise this looks good.

Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 51.84%. Comparing base (8118cfe) to head (c5aa428).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
netdeploy/network.go 0.00% 12 Missing ⚠️
cmd/algocfg/profileCommand.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6319      +/-   ##
==========================================
- Coverage   51.86%   51.84%   -0.03%     
==========================================
  Files         652      652              
  Lines       87442    87457      +15     
==========================================
- Hits        45353    45341      -12     
- Misses      39227    39247      +20     
- Partials     2862     2869       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@algorandskiy algorandskiy requested review from gmalouf and jannotti May 14, 2025 20:24
@gmalouf gmalouf self-requested a review July 16, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants