-
Notifications
You must be signed in to change notification settings - Fork 505
config: enable hybrid mode by default #6319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
config: enable hybrid mode by default #6319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a user really doesn't want to run p2p, they would edit their config file by hand ahead of upgrade, and set it to false. Then we would respect that change because it's explicit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to add an additional algocfg
option for running a client with P2P disabled, but otherwise this looks good.
b6e12c9
to
048ad0c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6319 +/- ##
==========================================
- Coverage 51.86% 51.84% -0.03%
==========================================
Files 652 652
Lines 87442 87457 +15
==========================================
- Hits 45353 45341 -12
- Misses 39227 39247 +20
- Partials 2862 2869 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Set EnableP2PHybridMode to true in config defaults.
Most of the changes are about to make tests work with EnableP2PHybridMode=true. It is either to set
PublicAddress
andP2PHybridNetAddress
(e2e-subs, expect tests) or to overrideEnableP2PHybridMode
back to FALSE value (e2e-go).Test Plan
Existing tests