Skip to content

Conversation

@algorandskiy
Copy link
Contributor

Summary

Setting NetAddress and leaving P2PHybridNetAddress empty (and another way around) in hybrid mode might start a node with dual server-client mode that is not what operators expect.
Fixed by checking NetAddress and P2PHybridNetAddress for consistency if EnableP2PHybridMode is set.

Test Plan

Added new unit tests.

@algorandskiy algorandskiy requested review from cce and gmalouf September 13, 2024 16:56
@algorandskiy algorandskiy self-assigned this Sep 13, 2024
Copy link
Contributor

@gmalouf gmalouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.20%. Comparing base (3b3b5ce) to head (c958863).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6130      +/-   ##
==========================================
+ Coverage   54.28%   56.20%   +1.91%     
==========================================
  Files         494      494              
  Lines       69936    69943       +7     
==========================================
+ Hits        37968    39313    +1345     
+ Misses      29246    27957    -1289     
+ Partials     2722     2673      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants