tests: use temp file for capturing e2e goal-partkey-commands output #6115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
previously approved these changes
Aug 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6115 +/- ##
==========================================
+ Coverage 56.22% 56.28% +0.06%
==========================================
Files 490 490
Lines 69705 69705
==========================================
+ Hits 39191 39236 +45
+ Misses 27840 27802 -38
+ Partials 2674 2667 -7 ☔ View full report in Codecov by Sentry. |
Contributor
|
Codegen is also failing on this for what look like actual issues |
algorandskiy
previously approved these changes
Aug 29, 2024
cce
force-pushed
the
goal-partkey-shell
branch
from
8147484 to
8925325
Compare
…caught it earlier
cce
force-pushed
the
goal-partkey-shell
branch
from
24ba9a4 to
227be8c
Compare
Contributor
Author
algorandskiy
approved these changes
Aug 30, 2024
ohill
approved these changes
Aug 30, 2024
Contributor
ohill
left a comment
ohill
left a comment
There was a problem hiding this comment.
👍 Let's remove some of the ignored shellcheck warnings and expand the list of directories it checks later!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since #6095 fixed issues with this test, it seems to fail occasionally with long goal outputs. This attempts to fix the issue like seen in https://app.circleci.com/pipelines/github/algorand/go-algorand/18982/workflows/7b9dc41e-1521-436c-afe2-6d365c07fb57/jobs/277753
Test Plan
Hopes to reduce occasional E2E test failures.
Adds a shellcheck in e2e_subs to CI that would have caught the bug found in #6095 where
${gcmd}was being called without being defined.