AVM: Derive looser, but more principled, checks of txn max size #6114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
previously approved these changes
Aug 29, 2024
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
Makes sense to me, though I have some minor comments
Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
jasonpaulos
approved these changes
Aug 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6114 +/- ##
==========================================
+ Coverage 56.27% 56.28% +0.01%
==========================================
Files 490 490
Lines 69710 69710
==========================================
+ Hits 39230 39238 +8
+ Misses 27817 27806 -11
- Partials 2663 2666 +3 ☔ View full report in Codecov by Sentry. |
algorandskiy
approved these changes
Sep 6, 2024
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
Looks reasonable to me
gmalouf
approved these changes
Sep 9, 2024
giuliop
added a commit
to giuliop/go-algorand
that referenced
this pull request
Sep 9, 2024
This reverts commit 91d6e09 which is not needed anymore after the merge of: AVM: Derive looser, but more principled, checks of txn max size algorand#6114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better checks on max txn size that will work better as we make changes.