-
Notifications
You must be signed in to change notification settings - Fork 524
p2p: Telemetry and metrics improvements #6104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: Telemetry and metrics improvements #6104
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6104 +/- ##
==========================================
- Coverage 56.22% 56.21% -0.02%
==========================================
Files 490 490
Lines 69705 69710 +5
==========================================
- Hits 39191 39186 -5
- Misses 27840 27851 +11
+ Partials 2674 2673 -1 ☔ View full report in Codecov by Sentry. |
20c32ae to
1262954
Compare
1262954 to
3eb13b0
Compare
|
Fixed SendRPC checks |
cce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than Publish[i] LGTM
Co-authored-by: cce <51567+cce@users.noreply.github.com>
|
Closing, #6105 has all of it and much more. |
Summary
EnableP2PandEnableP2PHybridModeto the telemetryStartupevent. This will allow to see fractions of WS, P2P and Hybrid nodes.pubsubTracer.SendRPCimplementation to track TX messages being broadcasted over the network. These will be the same asalgod_network_sent_bytes_TXandalgod_network_message_sent_TX.This is part 1 of a bigger change to separate metrics like
algod_network_sent_bytes_{TAG}for ws and p2p networks. The newly addedalgod_transaction_messages_p2p_sentwill be replaced byalgod_network_message_sent_TXbut this requires moving all of these into theutil/metricsto be used in bothnetworkpackage andnetwork/p2psub-packages. This would also allow to write a simple unit test for gossipsub metric (having the counter available in the node or network package).Test Plan
Tested locally with
goal network+pingpong+test/heapwatch/heapWatch.py --period 10 --metrics