Skip to content

Conversation

@algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Jul 31, 2024

Summary

Add a new option -i/--ignore to netgoal build to suppress errors like error building network files: error loading Network Config file 'net.json': config file contains unrecognized token: {{.Year}} when using LogArchiveName templating in ConfigJSONOverride

Also renamed ErrDeployedNetworkTemplate error type to deployedNetworkTemplateError to match err val vs err type convention used in other parts of the code base (err- prefix for values, -Error suffix for types).

Test Plan

Tested locally

@codecov
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 56.26%. Comparing base (05a52e2) to head (298a6d7).

Files Patch % Lines
netdeploy/remote/deployedNetwork.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6091      +/-   ##
==========================================
+ Coverage   55.88%   56.26%   +0.37%     
==========================================
  Files         488      488              
  Lines       69610    69612       +2     
==========================================
+ Hits        38901    39165     +264     
+ Misses      28042    27782     -260     
+ Partials     2667     2665       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants