Skip to content

Conversation

@algorandskiy
Copy link
Contributor

Summary

RawTransactionAsync exposes ability to submit transactions to network without validation and exposed as experimental API. Algod also exposes assets endpoint as experimental (#5948) and has ability to disable auth tokens completely (#6067), this makes easy to mis-configure a node and have RawTransactionAsync enabled.

To address I made RawTransactionAsync developer API (in addition to experimental).

Test Plan

Extended unit test.

@codecov
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.31%. Comparing base (1493410) to head (e3da643).

Files Patch % Lines
daemon/algod/api/server/v2/handlers.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6069      +/-   ##
==========================================
- Coverage   55.77%   55.31%   -0.47%     
==========================================
  Files         488      488              
  Lines       69434    69436       +2     
==========================================
- Hits        38730    38408     -322     
- Misses      28017    28358     +341     
+ Partials     2687     2670      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants