tests: disable TestP2PRelay on CI #6059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6059 +/- ##
==========================================
- Coverage 56.16% 55.83% -0.33%
==========================================
Files 488 488
Lines 69432 69432
==========================================
- Hits 38995 38770 -225
- Misses 27792 27983 +191
- Partials 2645 2679 +34 ☔ View full report in Codecov by Sentry. |
gmalouf
previously approved these changes
Jul 9, 2024
cce
previously approved these changes
Jul 9, 2024
gmalouf
reviewed
Jul 9, 2024
This reverts commit 796a416.
algorandskiy
changed the title
gmalouf
reviewed
Jul 10, 2024
gmalouf
reviewed
Jul 10, 2024
Contributor
gmalouf
left a comment
gmalouf
left a comment
There was a problem hiding this comment.
Do we have any other coverage for the cases being disabled?
Contributor
Author
|
yes, there is |
gmalouf
approved these changes
Jul 10, 2024
cce
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempts to debug failures of
TestP2PRelayas well as hardening startup checks have not stabilized the test on CI.After adding pubsub traces there were no single failure in 7 runs in a row, so disabling this test as further debugging starts looking as a waste of time.
Also enabled debug logging in
TestVotersReloadFromDiskAfterOneStateProofCommittedsince it fails time to time.