CI: increase artifact upload timeout #6050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upload should never take this long, so it's puzzling.
ohill
approved these changes
Jul 3, 2024
algorandskiy
approved these changes
Jul 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6050 +/- ##
==========================================
+ Coverage 56.13% 56.16% +0.02%
==========================================
Files 488 488
Lines 69425 69425
==========================================
+ Hits 38973 38993 +20
+ Misses 27796 27779 -17
+ Partials 2656 2653 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While uploads usually take on the order of minutes, for Mac ARM64 for some reason it's taking longer than 10 minutes. It's not clear if it's stalled or just needs more time.
This PR increases the default from 10m to 20m.
Test Plan
Should merge and see if it resolves nightly issues, as well as length of time for successful uploads.