Skip to content

Conversation

@gmalouf
Copy link
Contributor

@gmalouf gmalouf commented Jul 2, 2024

Summary

This PR also introduces endpoint to retrieve local config in json format, scoped to private/admin API. It additionally adds a print to the algo-out file at startup of a fully hydrated/merged version of the configuration.

Test Plan

Added test for the new GetConfig endpoint.

@gmalouf gmalouf self-assigned this Jul 2, 2024
@codecov
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 56.15%. Comparing base (3bcfedb) to head (61982e4).
Report is 1 commits behind head on master.

Files Patch % Lines
cmd/algod/main.go 0.00% 5 Missing ⚠️
daemon/algod/api/server/v2/handlers.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6049      +/-   ##
==========================================
+ Coverage   56.13%   56.15%   +0.02%     
==========================================
  Files         488      488              
  Lines       69425    69432       +7     
==========================================
+ Hits        38973    38991      +18     
+ Misses      27796    27787       -9     
+ Partials     2656     2654       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetConfig REST LGTM

@gmalouf gmalouf changed the title Config: Maintain parameter overrides no matter version when loading/merging configuration Config: Expose merged configuration for easier debugging Jul 3, 2024
@gmalouf gmalouf marked this pull request as ready for review July 3, 2024 17:12
@gmalouf gmalouf merged commit b3c7bca into algorand:master Jul 8, 2024
@gmalouf gmalouf deleted the config-migration-preserve-overrides branch July 8, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants