CICD: remove mac AMD64 support from circleci #6036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As per CircleCI's announced deprecation the Mac AMD64 resource class is being deprecated. As a result we should disable these tests.
This PR also switches to using CircleCI's mac resources, instead of a self-hosted runner.
There is a larger question of how much support we should provide to Intel architecture in general. The last Intel mac was discontinued a year ago. A universal build like in #6023 would obviate the need for AMD64 build platforms and dealing with XCode deprecations, but would lead to insecurity about validity of tests.
Test Plan
Force nightly tests to execute against this branch.
Note: the test failure is from running the nightly execution, and the failure is unrelated to this change. It can be ignored.