libgoal: output debug info on failure to stderr #6027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
force-pushed
the
pavel/e2e-catchup-gossip-debug2
branch
from
6d91995 to
5bdb56d
Compare
jasonpaulos
previously approved these changes
Jun 12, 2024
gmalouf
previously approved these changes
Jun 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6027 +/- ##
==========================================
+ Coverage 55.86% 55.91% +0.04%
==========================================
Files 482 482
Lines 68457 68457
==========================================
+ Hits 38245 38278 +33
+ Misses 27608 27581 -27
+ Partials 2604 2598 -6 ☔ View full report in Codecov by Sentry. |
jasonpaulos
approved these changes
Jun 12, 2024
gmalouf
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The test failed again and again there is no debug info, probably because either test logger gone or some flushing issue.
Using
fmt.Fprintf(os.Stderr, ...)should take take about both about possibilities.Test Plan
This is a test harness change.