txHandler : Move streamverifer out of txn go #5039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5039 +/- ##
==========================================
- Coverage 53.40% 53.40% -0.01%
==========================================
Files 431 432 +1
Lines 54381 54381
==========================================
- Hits 29042 29040 -2
- Misses 23079 23080 +1
- Partials 2260 2261 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algonautshant
changed the title
brianolson
previously approved these changes
Feb 3, 2023
Contributor
brianolson
left a comment
brianolson
left a comment
There was a problem hiding this comment.
eyeball-hashed that it was just a code move. looks good.
…rifer_out_of_txn_go
…rifer_out_of_txn_go
algorandskiy
approved these changes
Feb 8, 2023
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
This is indeed a code move
icorderi
approved these changes
Feb 8, 2023
This was referenced Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #4621
In this change, the streamverifier is moved out of txn.go to its own file. Same for the tests.