Skip to content

Conversation

@michaeldiamant
Copy link
Contributor

Enables https://github.com/kunwardeep/paralleltest on shared by fixing linter warnings. Incrementally moves the ball towards greater unit test parallelization, which reduces local + CI test durations.

I vetted for flakiness by running:

go test -race -count 10 ./shared/...

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #4989 (a2293ce) into master (eddf773) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4989      +/-   ##
==========================================
- Coverage   53.63%   53.63%   -0.01%     
==========================================
  Files         432      432              
  Lines       54057    54057              
==========================================
- Hits        28996    28995       -1     
- Misses      22812    22817       +5     
+ Partials     2249     2245       -4     
Impacted Files Coverage Δ
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
ledger/tracker.go 74.26% <0.00%> (-0.85%) ⬇️
ledger/acctupdates.go 69.24% <0.00%> (-0.25%) ⬇️
network/wsNetwork.go 64.74% <0.00%> (ø)
ledger/testing/randomAccounts.go 56.88% <0.00%> (+0.61%) ⬆️
catchup/service.go 70.53% <0.00%> (+0.72%) ⬆️
ledger/store/merkle_commiter.go 62.96% <0.00%> (+11.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michaeldiamant michaeldiamant requested review from cce and removed request for jannotti January 11, 2023 19:18
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one test function that is being parallelized here, so the diff looks functionally equivalent to me. I'm okay with this change, but might be prudent for an extra approval.

@cce cce merged commit a1eaafb into master Jan 20, 2023
@cce cce deleted the parallelize_shared branch January 20, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants